Combine IPv4 UDP broadcast socket tests#13271
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1640.
What
Why
UDPBroadcastSendRecvOnSocketBoundToBroadcastandUDPBroadcastSendRecvOnSocketBoundToAnyhad identical bodies except for the source address. Parameterizing the address keeps the same behavioral coverage while removing the duplicate test body and the TODO/FIXME.Testing
git diff --checkbazel build --nobuild //test/syscalls/linux:socket_ipv4_udp_unbound_external_networking_testbazel test //test/syscalls/linux:socket_ipv4_udp_unbound_external_networking_test --test_output=errorswas attempted locally, but this macOS checkout cannot build Linux syscall tests: the host C++ toolchain first missed libc++ headers (<cerrno>,<functional>), and after adding the SDK libc++ include path it failed on Linux-only<sys/statfs.h>before compiling this target.