Skip to content

Combine UDP broadcast socket bind tests#13266

Open
Haihan-Jiang wants to merge 1 commit into
google:masterfrom
Haihan-Jiang:codex/gvisor-combine-udp-broadcast-tests
Open

Combine UDP broadcast socket bind tests#13266
Haihan-Jiang wants to merge 1 commit into
google:masterfrom
Haihan-Jiang:codex/gvisor-combine-udp-broadcast-tests

Conversation

@Haihan-Jiang
Copy link
Copy Markdown

@Haihan-Jiang Haihan-Jiang commented May 23, 2026

Updates #1640.

This combines the two IPv4 UDP broadcast send/receive tests that only differed
by the address used to bind the sending socket.

The change:

  • extracts the IPv4 external-networking interface setup into a shared base;
  • adds a parameterized fixture over (SocketKind, TestAddress);
  • instantiates the broadcast send/receive test with V4Broadcast() and
    V4Any().

Validation:

  • git diff --check
  • bazel build --nobuild --macos_sdk_version=$(xcrun --show-sdk-version) -- //test/syscalls/linux:socket_ipv4_udp_unbound_external_networking_test
  • Linux execution through the gVisor build container:
    ./bazel-bin/test/syscalls/linux/socket_ipv4_udp_unbound_external_networking_test
    passed 38/38 tests.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 23, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Assisted-by: OpenAI Codex
@Haihan-Jiang Haihan-Jiang force-pushed the codex/gvisor-combine-udp-broadcast-tests branch from 4059097 to 854b337 Compare May 23, 2026 11:16
@Haihan-Jiang Haihan-Jiang marked this pull request as ready for review May 23, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant