Allow netlink sockets to send to RTMGRP_LINK #12287
Merged
+336
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl830546353
branch
from
25db030 to
7d3a75b
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test/cl830546353
branch
3 times, most recently
from
f99b348 to
6237637
Compare
sendmsg() to the multicast group now works. connect() is still disallowed. This patch also reduces the length for which a netlink socket's mu is held. Previously, once it was taken in Socket.sendMsg(), it was held throughout Protocol.Receive() -> Socket.ProcessMessages() -> Socket.SendResponse(). When in fact the only field it was needed for was Socket.portID. PiperOrigin-RevId: 836418153
copybara-service
bot
force-pushed
the
test/cl830546353
branch
from
6237637 to
95f8769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow netlink sockets to send to RTMGRP_LINK
sendmsg() to the multicast group now works. connect() is still disallowed.
This patch also reduces the length for which a netlink socket's mu is held.
Previously, once it was taken in Socket.sendMsg(), it was held throughout
Protocol.Receive() -> Socket.ProcessMessages() -> Socket.SendResponse().
When in fact the only field it was needed for was Socket.portID.