Skip to content

Update domain classes to include map data for PDF rendering#3844

Open
andreia-ferreira wants to merge 7 commits into
masterfrom
andreia/3839/update-domain
Open

Update domain classes to include map data for PDF rendering#3844
andreia-ferreira wants to merge 7 commits into
masterfrom
andreia/3839/update-domain

Conversation

@andreia-ferreira

@andreia-ferreira andreia-ferreira commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Towards #3839

This PR focuses on updating domain models to prepare for including a map with the polygon drawn on it in the PDF report:

  • LoiReport now carries the geometry and the style, so that the polygon can be included in a similar style as the one defined by the job
  • SubmissionPdfDocument contains a new mapBlock which has all the needed information to be able to render the new component later
  • New strings for the area and scale were added

There are no behavior changes in this PR, but the new logic is covered by unit tests.

@shobhitagarwal1612 PTAL?

@andreia-ferreira andreia-ferreira changed the title Andreia/3839/update domain Update domain classes to include map data for PDF rendering Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.16%. Comparing base (82cc1d0) to head (46b5d35).

Files with missing lines Patch % Lines
.../ui/datacollection/DataCollectionScreenPreviews.kt 0.00% 2 Missing ⚠️
...id/ui/home/mapcontainer/jobs/ShareLocationModal.kt 0.00% 2 Missing ⚠️
...oundplatform/feature/pdf/mapper/LoiReportMapper.kt 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3844      +/-   ##
============================================
+ Coverage     67.10%   67.16%   +0.06%     
- Complexity     1803     1810       +7     
============================================
  Files           406      406              
  Lines         10645    10677      +32     
  Branches       1398     1401       +3     
============================================
+ Hits           7143     7171      +28     
- Misses         2759     2763       +4     
  Partials        743      743              
Files with missing lines Coverage Δ
...datacollection/DataSubmissionConfirmationScreen.kt 86.36% <100.00%> (+0.25%) ⬆️
...tform/domain/model/locationofinterest/LoiReport.kt 100.00% <100.00%> (ø)
...undplatform/domain/usecases/GetLoiReportUseCase.kt 90.76% <100.00%> (+0.44%) ⬆️
...latform/feature/pdf/model/SubmissionPdfDocument.kt 93.54% <100.00%> (+1.88%) ⬆️
...oundplatform/feature/pdf/mapper/LoiReportMapper.kt 91.17% <92.85%> (+0.43%) ⬆️
.../ui/datacollection/DataCollectionScreenPreviews.kt 0.00% <0.00%> (ø)
...id/ui/home/mapcontainer/jobs/ShareLocationModal.kt 63.23% <0.00%> (-1.92%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants