Fix panic on malformed Dot11 InformationElement packets#1232
Open
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Open
Fix panic on malformed Dot11 InformationElement packets#1232mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Conversation
For vendor IEs (ID=221), check m.Length >= 4 before reading OUI and splitting data. The previous bounds check was applied to all IE types regardless of vendor status, and did not prevent a panic when a vendor IE had Length < 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix bounds checking for vendor IEs (ID=221) in
Dot11InformationElement.DecodeFromBytes.Root cause: For vendor IEs, the code reads
data[offset+4:offset+int(m.Length)]to extract Info after the 4-byte OUI. Whenm.Length < 4, this creates an invalid slice with a negative length, causing a panic. The previouslen(data) < offset+4check was also incorrectly applied to all IE types, not just vendor extensions.Fix: Move the length check inside the vendor IE branch and validate
m.Length >= 4before splitting OUI from Info.All existing tests pass.