Fix panic on malformed PrismHeader packets#1231
Open
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Open
Fix panic on malformed PrismHeader packets#1231mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Conversation
Add minimum data length check and validate PrismHeader.Length against actual data length before using it for slicing. Malformed packets with short data or inflated Length fields caused slice bounds panics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add minimum data length check and validate
PrismHeader.LengthinDecodeFromBytes.Root cause: No minimum length check before reading the 24-byte header (Code, Length, DeviceName). The
m.Lengthfield from the packet is used fordata[:m.Length]anddata[m.Length:]slicing without validating it againstlen(data).Fix: Check
len(data) >= 24before header reads. Return an error ifm.Length > len(data).All existing tests pass.