Fix panic on malformed SFlow packets#1228
Open
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Open
Fix panic on malformed SFlow packets#1228mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Conversation
Add bounds checking in SFlowDatagram.DecodeFromBytes before reading header fields. The chained data/field assignments assumed sufficient data length, causing slice bounds panics on truncated packets, short agent addresses, and missing sample data. Return an error instead of panicking when data is too short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bounds checking in
SFlowDatagram.DecodeFromBytesbefore reading header fields to prevent panics on malformed packets.Root cause: Chained assignments like
data, s.X = data[4:], binary.BigEndian.Uint32(data[:4])assume sufficient data remains. No minimum length check exists. Agent address length from the packet is used for slicing without validation.Fix: Add minimum length check at entry, validate remaining data against agent address length + required header fields, and check data length before sample iteration.
Panics fixed: 5 (too short, truncated after version, IPv6 truncated, large sample count, bad agent type)
All existing tests pass.