Fix panic on malformed RadioTap packets#1227
Open
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Open
Fix panic on malformed RadioTap packets#1227mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Conversation
Add bounds checking in RadioTap.DecodeFromBytes before each field read. Malformed packets with truncated data or invalid Length fields caused index out of range panics via the extended bitmap loop, individual field reads (TSFT, Channel, MCS, AMPDU, VHT, etc.), and payload extraction. Return an error instead of panicking when data is too short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bounds checking in
RadioTap.DecodeFromBytesbefore each field read to prevent panics on malformed packets.Root cause: After the initial 8-byte minimum check, the extended bitmap loop and all field reads (TSFT, Channel, MCS, AMPDU, VHT, etc.) access
data[offset:offset+N]without verifyingoffset+N <= len(data). The payload extraction atdata[m.Length:]trusts the header's Length field without validation.Fix: Check remaining data length before each field read and before payload extraction. Return a descriptive error instead of panicking.
Panics fixed: 6 (extended bitmap loop, TSFT, Channel, MCS, VHT, payload length)
All existing tests pass.