Skip to content

Use inherited EMPTY_RANGE in JavaOutput to eliminate Formatter dependency. #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 10, 2026
+2 −2
Merged

Use inherited EMPTY_RANGE in JavaOutput to eliminate Formatter dependency. #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
if (!range.isEmpty()) {
if (!rangesSet) {
while (ranges.size() <= mutableLines.size()) {
ranges.add(Formatter.EMPTY_RANGE);
ranges.add(EMPTY_RANGE);
}
ranges.set(mutableLines.size(), union(ranges.get(mutableLines.size()), range));
rangesSet = true;
Expand All @@ -179,7 +179,7 @@

@Override
public void indent(int indent) {
spacesPending.append(Strings.repeat(" ", indent));

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 21 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 21 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on macos-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on macos-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on macos-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on macos-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 25 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 21 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / JDK 21 on ubuntu-latest 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only

Check warning on line 182 in core/src/main/java/com/google/googlejavaformat/java/JavaOutput.java

View workflow job for this annotation

GitHub Actions / Publish snapshot 

[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only
}

/** Flush any incomplete last line, then add the EOF token into our data structures. */
Expand All @@ -191,7 +191,7 @@
int jN = mutableLines.size();
Range<Integer> eofRange = Range.closedOpen(kN, kN + 1);
while (ranges.size() < jN) {
ranges.add(Formatter.EMPTY_RANGE);
ranges.add(EMPTY_RANGE);
}
ranges.add(eofRange);
setLines(ImmutableList.copyOf(mutableLines));
Expand Down
Loading