Repository navigation
Conversation
BaseURL relative path for rate limit category
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4644 +/- ##
=======================================
Coverage 98.61% 98.62%
=======================================
Files 199 199
Lines 18694 18700 +6
=======================================
+ Hits 18436 18442 +6
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
auraseb
force-pushed
the
fix/ghes-rate-limit-category
branch
from
October 18, 2026 13:23
745ddfd to
9dd7286
Compare
gmlewis
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bareDopassedreq.URL.PathtoGetRateLimitCategory, so on a client whose BaseURL has a path (GitHub Enterprise Server,/api/v3/) no prefix rule matched and search, code search, SCIM, source import, snapshot, SBOM and app manifest requests were all filed underCoreCategory. An exhausted code search limit then blocked unrelated core requests until it reset.This strips the BaseURL path before categorizing. github.com clients are unaffected since their BaseURL path is
/.Tests:
TestDo_rateLimitCategory_baseURLPathfails without the change: an exhaustedsearch/codelimit lands inrateLimits[CoreCategory]and blocks a followingGET user.CoreCategorywith the test server's/api-v3/base path, which only worked because of this bug. They now pass their real category totestNewRequestAndDoFailureCategory.Fixes #4643