Draft
Conversation
This was referenced Apr 14, 2026
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
request-context-refactor
branch
from
691467f to
361db80
Compare
alexandear
reviewed
Apr 14, 2026
Comment on lines
+94
to
100
| req, err := s.client.NewRequest(ctx, "GET", u, nil) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| var artifactList *ArtifactList | ||
| resp, err := s.client.Do(ctx, req, &artifactList) |
Contributor
There was a problem hiding this comment.
It's a bit odd that both NewRequest and Do accept ctx.
Contributor
Author
There was a problem hiding this comment.
It is, but the logic for per request rate limiting uses the context. I could refactor it to use req.Context() but that seems like additional overhead when the context is already available to be passed in.
gmlewis
added
NeedsReview
Contributor
Author
|
@gmlewis I'm going to completely rebase this PR as I need to split it into 3. |
Contributor
Author
|
#4152 replaces the app engine removal part of this PR. |
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4127
Related to #3915
This PR makes the following changes:
http.NewRequestWithContextso we no longer need thewithContexthelperclient.BareDoto get benefits such as rate limitDownloadReleaseAssetto usebareDoUntilFoundinstead of mutating the global client to block redirectsappenginebuild tag)