Change a few functions that take const {ByteArray, string}& to take ByteSpan.#1986
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Change a few functions that take const {ByteArray, string}& to take ByteSpan.#1986copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
cl/869731297
branch
from
b88fda9 to
f7e8127
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
cl/869731297
branch
4 times, most recently
from
b3ebeb3 to
dff758e
Compare
…yteSpan.
This is to avoid copying the underlying data when converting data types for those functions.
E.g. there will be no need to copy data from a vector of `Mutant` to execute them.
Another example is that RemoteFileAppend(std::string) used to copy the data to a ByteArray, but not needed after.
Also changes dependent functions that take const vector<{ByteArray,string}>& to take span<const ByteSpan>, and const vector<MutateInputRef>& -> span<const MutateInputRef> following the same spirit.
PiperOrigin-RevId: 869731297
copybara-service
bot
force-pushed
the
cl/869731297
branch
from
dff758e to
978ca9a
Compare
copybara-service
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change a few functions that take const {ByteArray, string}& to take ByteSpan.
This is to avoid copying the underlying data when converting data types for those functions.
E.g. there will be no need to copy data from a vector of
Mutantto execute them.Another example is that RemoteFileAppend(std::string) used to copy the data to a ByteArray, but not needed after.
Also changes dependent functions that take const vector<{ByteArray,string}>& to take span, and const vector& -> span following the same spirit.