Require Python sdists in release workflows#9018
Open
steadytao wants to merge 1 commit intogoogle:masterfrom
Open
Require Python sdists in release workflows#9018steadytao wants to merge 1 commit intogoogle:masterfrom
steadytao wants to merge 1 commit intogoogle:masterfrom
Conversation
Build and validate both wheel and source distribution artifacts in Python CI and before PyPI upload. Fail the workflow if either artifact is missing so wheel-only Python releases cannot slip through again. Fixes google#8895
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add release guards so Python packaging workflows require both a wheel and a source distribution.
Problem
Issue #8895 reports that the PyPI release for
25.12.19was uploaded without an sdist.That is a release-process failure rather than a runtime code bug, and it is useful to prevent directly in CI and release automation.
Fix
twine checkon the built artifactsTesting
python -m buildinpython/flatbuffers-25.12.19-py3-none-any.whlflatbuffers-25.12.19.tar.gzFixes #8895.