Stage the Python license file during builds#9015
Open
steadytao wants to merge 1 commit intogoogle:masterfrom
Open
Stage the Python license file during builds#9015steadytao wants to merge 1 commit intogoogle:masterfrom
steadytao wants to merge 1 commit intogoogle:masterfrom
Conversation
Copy the repo-root LICENSE into the Python package directory for the duration of setup() so license_files = LICENSE remains valid without using deprecated parent-directory paths. Remove the staged copy after the build completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage the repo-root
LICENSEfile into the Python package directory during builds.Problem
The Python package can no longer use
../LICENSEinlicense_filesbut the currentlicense_files = LICENSEconfiguration also warns becausepython/LICENSEdoes not exist at build time.Fix
LICENSEinto the Python package directory before callingsetup()license_files = LICENSETesting
python -m buildinpython/license_fileswarning is gonedist-info/licenses/LICENSEpython/LICENSEfile is removed after the buildFixes #8789.