Fix Lua table field builder slot generation#9014
Open
steadytao wants to merge 1 commit intogoogle:masterfrom
Open
Fix Lua table field builder slot generation#9014steadytao wants to merge 1 commit intogoogle:masterfrom
steadytao wants to merge 1 commit intogoogle:masterfrom
Conversation
Make the Lua generator use UOffset-relative slots for table fields instead of treating all object references as structs. Add a Lua regression schema and runtime test for packing a nested table field. Fixes google#8611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Lua generator use
PrependUOffsetTRelativeSlotfor table fields instead ofPrependStructSlot.Problem
The Lua generator treated both structs and tables as
Structwhen selecting the builder slot method for table fields.For a schema like:
it generated:
but
customeris a table offset, not an inline struct. This causes packing to fail with:Tried to write a Struct at an Offset that is different from the current Offset of the Builder.Fix
Structbuilder methods for actual struct fieldsUOffsetTRelativefor table fieldsTesting
flatcCustomer/SaleschemaSale.AddCustomernow usesPrependUOffsetTRelativeSlot8 / 8tests passedFixes #8611