Fix Python object API packing with no type prefixes#9013
Open
steadytao wants to merge 1 commit intogoogle:masterfrom
Open
Fix Python object API packing with no type prefixes#9013steadytao wants to merge 1 commit intogoogle:masterfrom
steadytao wants to merge 1 commit intogoogle:masterfrom
Conversation
Make Python object API Pack generation respect --python-no-type-prefix-suffix for table start, add, end, and vector helper calls. Add a regression schema and Python test covering the nested-table Pack path reported in google#8715. Fixes google#8715
github-actions
bot
added
python
c++
codegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Python object API
Pack()generation respect--python-no-type-prefix-suffix.Problem
When
--gen-object-apiand--python-no-type-prefix-suffixwere used together, the generated Python helper functions were emitted without type prefixes but the object APIPack()methods still called prefixed names such asTableBooStart,TableBooAddTable1andTableBooEnd.That made the generated object API unusable with this flag combination.
Fix
Testing
flatc--gen-object-api --python-no-type-prefix-suffixTestObjectBasedAPIsuite locallyFixes #8715