Avoid double-free on duplicate enum names during BFBS deserialization#9012
Open
steadytao wants to merge 2 commits intogoogle:masterfrom
Open
Avoid double-free on duplicate enum names during BFBS deserialization#9012steadytao wants to merge 2 commits intogoogle:masterfrom
steadytao wants to merge 2 commits intogoogle:masterfrom
Conversation
SymbolTable::Add() appended objects to its ownership vector before checking for duplicate names. During binary schema deserialization this allowed duplicate enum names to leave a freed pointer behind, which was later deleted again during teardown. Check for duplicates before storing the pointer and add a regression test that verifies a malformed BFBS fixture is accepted by VerifySchemaBuffer() but rejected safely by Parser::Deserialize(). Tested with flattests.exe; all tests passed.
jtdavis777
previously approved these changes
Apr 3, 2026
Delete the temporary EnumDef in Parser::StartEnum() when duplicate-name registration fails so duplicate enum/union declarations do not leak during parsing.
Author
|
CIFuzz found a real follow-up leak in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject duplicate enum names during BFBS deserialisation before transferring ownership into the symbol table.
Problem
SymbolTable::Add()appended objects to its ownership vector before checking for duplicate names. During binary schema deserialisation, duplicate enum names could therefore leave a freed pointer behind in the symbol table and later trigger a double-free during teardown.Fix
VerifySchemaBuffer()accepts the schema butParser::Deserialize()rejects it safelyTesting
flattests.exeALL TESTS PASSEDFixes #9009