Reject unterminated FlexBuffers keys during verification#9011
Open
steadytao wants to merge 1 commit intogoogle:masterfrom
Open
Reject unterminated FlexBuffers keys during verification#9011steadytao wants to merge 1 commit intogoogle:masterfrom
steadytao wants to merge 1 commit intogoogle:masterfrom
Conversation
VerifyKey() returned success after encountering any non-zero byte, which allowed malformed FBT_KEY values without a terminating NUL byte to pass VerifyBuffer(). Require a NUL terminator before the end of the buffer and add a regression test for the 4-byte malformed input from issue google#9008. Tested with flattests.exe; all tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject malformed FlexBuffers keys that are not NUL-terminated within the buffer.
Problem
VerifyKey()returned success after encountering any non-zero byte, which allowed malformedFBT_KEYvalues without a terminating NUL byte to passVerifyBuffer().Fix
Require a NUL terminator before the end of the buffer and add a regression test for the 4-byte malformed input from issue #9008.
Testing
flattests.exeFixes #9008