prevent out-of-bounds access in ForAllFields#9000
Open
metsw24-max wants to merge 2 commits intogoogle:masterfrom
Open
prevent out-of-bounds access in ForAllFields#9000metsw24-max wants to merge 2 commits intogoogle:masterfrom
metsw24-max wants to merge 2 commits intogoogle:masterfrom
Conversation
jtdavis777
requested changes
Mar 28, 2026
Author
|
@jtdavis777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an out-of-bounds access in ForAllFields caused by using
field->id()as an unchecked index into an internal mapping. Malformed or adversarial schemas can provide out-of-range field IDs, leading to heap-buffer-overflow reads and writes during field traversal. This change adds a bounds check, uses a sentinel-based mapping to avoid invalid entries, and corrects reverse iteration indexing, eliminating both memory safety issues and duplicate traversal artifacts while preserving behavior for valid schemas. The issue was reproduced with AddressSanitizer and is now resolved