Skip to content

* fix for https://github.com/google/flatbuffers/issues/8759 #8910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stefan301Zk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

* fix for https://github.com/google/flatbuffers/issues/8759 #8910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion net/FlatBuffers/Table.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public T[] __vector_as_array<T>(int offset)

var pos = this.__vector(o);
var len = this.__vector_len(o);
return bb.ToArray<T>(pos, len);
return bb.ToArray<T>(pos, len * ByteBuffer.SizeOf<T>());
}

// Initialize any Table-derived type to point to the union at the given offset.
Expand Down
14 changes: 13 additions & 1 deletion tests/FlatBuffers.Test/FlatBuffersExampleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
* Copyright 2014 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -90,6 +90,9 @@ private void CanCreateNewFlatBufferFromScratch(bool sizePrefix)
fbb.AddOffset(test1.Value);
var testArrayOfString = fbb.EndVector();

var longsVector = Monster.CreateVectorOfLongsVector(fbb, new long[] { 1, 100, 10000, 1000000, 100000000 });
var doublesVector = Monster.CreateVectorOfDoublesVector(fbb, new double[] { -1.7976931348623157e+308, 0, 1.7976931348623157e+308 });

Monster.StartMonster(fbb);
Monster.AddPos(fbb, Vec3.CreateVec3(fbb, 1.0f, 2.0f, 3.0f, 3.0,
Color.Green, (short)5, (sbyte)6));
Expand All @@ -102,6 +105,8 @@ private void CanCreateNewFlatBufferFromScratch(bool sizePrefix)
Monster.AddTestarrayofstring(fbb, testArrayOfString);
Monster.AddTestbool(fbb, true);
Monster.AddTestarrayoftables(fbb, sortMons);
Monster.AddVectorOfLongs(fbb, longsVector);
Monster.AddVectorOfDoubles(fbb, doublesVector);
var mon = Monster.EndMonster(fbb);

if (sizePrefix)
Expand Down Expand Up @@ -285,6 +290,13 @@ private void TestBuffer(ByteBuffer bb)
Assert.IsTrue(monster.GetTestarrayofboolsBytes().HasValue);
}
#endif

var longArray = monster.GetVectorOfLongsArray();
Assert.AreEqual(5, longArray.Length);
Assert.AreEqual(100, longArray[1]);

var doublesArray = monster.GetVectorOfDoublesArray();
Assert.AreEqual(3, doublesArray.Length);
}

[FlatBuffersTestMethod]
Expand Down