Fix codegen imports for public tagging utilities - #621
Open
Linxiushen wants to merge 1 commit into
Open
Linxiushen wants to merge 1 commit into
Linxiushen wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Linxiushen
force-pushed
the
fix/tagging-codegen-imports
branch
from
September 28, 2026 03:51
c078588 to
ed61a21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating configuration code for
fiddle.tagging.list_tagsormaterialize_tagscurrently emits nonexistentfdlattributes, so executing the fixture raisesAttributeError. Select public import aliases for these two symbols while preserving existing root-package aliases and user-registered overrides.Adds executable import-identity checks (including namespace collisions), modern configuration roundtrip/build coverage, and a legacy Partial roundtrip. Addresses the tagging-utility portion of #564; this does not close the separate TaggedValue import cases.
Validation: Python 3.12 on Linux with the full
[testing]dependencies:pytest fiddle— 1,114 passed, 4 skipped, 350 subtests passed. Pytype passes for both changed production files. New regressions fail on the unchanged source; publicnew_codegenandauto_config_codegengenerated modules also reconstruct and build successfully.