Skip to content

Fix codegen imports for public tagging utilities - #621

Open
Linxiushen wants to merge 1 commit into
google:mainfrom
Linxiushen:fix/tagging-codegen-imports
Open

Linxiushen wants to merge 1 commit into
google:mainfrom
Linxiushen:fix/tagging-codegen-imports

Conversation

@Linxiushen

Copy link
Copy Markdown

Generating configuration code for fiddle.tagging.list_tags or materialize_tags currently emits nonexistent fdl attributes, so executing the fixture raises AttributeError. Select public import aliases for these two symbols while preserving existing root-package aliases and user-registered overrides.

Adds executable import-identity checks (including namespace collisions), modern configuration roundtrip/build coverage, and a legacy Partial roundtrip. Addresses the tagging-utility portion of #564; this does not close the separate TaggedValue import cases.

Validation: Python 3.12 on Linux with the full [testing] dependencies: pytest fiddle — 1,114 passed, 4 skipped, 350 subtests passed. Pytype passes for both changed production files. New regressions fail on the unchanged source; public new_codegen and auto_config_codegen generated modules also reconstruct and build successfully.

@google-cla

google-cla Bot commented Sep 27, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Linxiushen
Linxiushen force-pushed the fix/tagging-codegen-imports branch from c078588 to ed61a21 Compare September 28, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant