Keep registered immutable objects alive to prevent object ID reuse. - #620
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_988516487
branch
2 times, most recently
from
September 26, 2026 08:20
7d3148f to
e42dc81
Compare
Store `id(value) -> value` in `_IMMUTABLE_OBJECT_IDS` and `_FUNCTIONS_WITH_IMMUTABLE_RETURN_VALUES` instead of storing only `id(value)` in sets, so registered objects are not garbage collected and their memory addresses cannot be reused by newly allocated objects. PiperOrigin-RevId: 988745384
copybara-service
Bot
force-pushed
the
test_988516487
branch
from
September 26, 2026 08:25
e42dc81 to
5823b29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep registered immutable objects alive to prevent object ID reuse.
Store
id(value) -> valuein_IMMUTABLE_OBJECT_IDSand_FUNCTIONS_WITH_IMMUTABLE_RETURN_VALUESinstead of storing onlyid(value)in sets, so registered objects are not garbage collected and their memory addresses cannot be reused by newly allocated objects.