Skip to content

Conversation

@dneto0
Copy link
Collaborator

@dneto0 dneto0 commented Jan 10, 2025

Fix msvc-14.4 x86 config to actually configure Win32.

Use cmake --build to build, instead of hardcoding the path to msbuild

Pass target CPU architecture explicitly vis BUILD_TARGET_ARCH

Use cmake --build to build, instead of hardcoding the path to msbuild
@dneto0 dneto0 requested a review from amaiorano January 10, 2025 22:29
@dneto0 dneto0 merged commit 167b131 into google:main Jan 10, 2025
10 checks passed
@dneto0
Copy link
Collaborator Author

dneto0 commented Jan 10, 2025

TBR: amaiorano@

sssooonnnggg pushed a commit to sssooonnnggg/cppdap that referenced this pull request Feb 6, 2025
Pass target CPU architecture explicitly vis BUILD_TARGET_ARCH

Use cmake --build to build, instead of hardcoding the path to msbuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant