Idiomatic: Simplify example in method resolution slide#3166
Open
randomPoison wants to merge 1 commit into
Open
Idiomatic: Simplify example in method resolution slide#3166randomPoison wants to merge 1 commit into
randomPoison wants to merge 1 commit into
Conversation
gribozavr
reviewed
Jun 9, 2026
| `&mut self` has a higher priority than `&self`, the one used by the inherent | ||
| method. | ||
| Demonstrate: Change the call to `(&-1i32).count_ones()` and demonstrate that | ||
| the trait method is now called instead. |
Collaborator
There was a problem hiding this comment.
I'm not sure that this new example demonstrates the rule described above. Could you help me understand? The difference is the method receiver expression, value -1i32 vs. reference &-1i32. The list above that describes the rule does not talk about that axis?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in the speaker notes can be a bit simpler, i.e. we can do
&instead of&mutand get the same effect. I also cut the comment down to reduce verbosity.