WIP: Add unit test for template literal concatenation (Issue #4148) #4257
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey Rahul! I think your approach sounds great, thanks for finding this issue, looking forward to seeing your planned out next steps! |
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
…s are not merged in ADVANCED mode" Upon further investigation it appears that template literals (specifically those that can't be optimized to strings) are not add folded when transpiling to ES6 or above What’s in this CL: - ONLY addressing case of template literal + template literal (added TODO for other cases) in PeepholeFoldConstants. - added associated unit tests PiperOrigin-RevId: 833853572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR starts addressing Issue #4148 (Concatenated template literals are not merged in ADVANCED mode).
What’s in this draft:
+should be merged into a single template literal.Next steps (planned):
- string + template literal (with any order)
- string + string (already working)
- template literal + template literal (template literal can include referenced variable or valid HTML)
Opening early for review to validate direction before proceeding.