Skip to content

Upgrade to River 2.0, compose dataset and repo, and enforce withdrawa… - #15

Merged
Sajmani merged 2 commits into
mainfrom
river-v2
Nov 12, 2026
Merged

Sajmani merged 2 commits into
mainfrom
river-v2

Conversation

@Sajmani

@Sajmani Sajmani commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

…l cascade

  • Install the River 2.0 skill under .agents/skills/river/ (pin 2b57ed5), hoist the module declaration to river/README.md, add sums.md and approvals.md, and retire the copied 1.0 checker in river/check/.
  • Split tech.fetchRestrictedInputs, product.selfDescriptionStaysTrue, and tech.localNowPublicLater into pure local intent plus composed obligations (decisions.riverV2PackagesAndSplits), and record goldmark and github.com in river/requirements/imports.md.
  • Compose internal/app, internal/dataset (carrying the four morphometric and badge-color models), and internal/repo across all 112 local and 34 imported requirements; migrate all 136 live criteria to each package's acceptance.md, drop 20 withdrawn/obsolete criteria, fix app.attributionComplete, and move mutable guardrail bindings and Watched failing: observations to river/conformance.md.
  • Re-point TestLumpsMergeIntoTheSpeciesBirdViewCarries to dataset.scopeMatchesStatusTable, delete dead functions left behind by retired requirements and tools, and add TestNoUnreachableCode (repo.noUnreachableCode) with its test-oracle allowlist.
  • Add a conditional river check job to .github/workflows/checks.yml and close adoptRiverWithdrawalCascade, composeDatasetAndRepo, separateRestatedRequirements, licenseConditionFirst, and attributionCriterionNamesAba.

…l cascade

- Install the River 2.0 skill under .agents/skills/river/ (pin 2b57ed5),
  hoist the module declaration to river/README.md, add sums.md and
  approvals.md, and retire the copied 1.0 checker in river/check/.
- Split tech.fetchRestrictedInputs, product.selfDescriptionStaysTrue, and
  tech.localNowPublicLater into pure local intent plus composed obligations
  (decisions.riverV2PackagesAndSplits), and record goldmark and github.com in
  river/requirements/imports.md.
- Compose internal/app, internal/dataset (carrying the four morphometric and
  badge-color models), and internal/repo across all 112 local and 34 imported
  requirements; migrate all 136 live criteria to each package's acceptance.md,
  drop 20 withdrawn/obsolete criteria, fix app.attributionComplete, and move
  mutable guardrail bindings and Watched failing: observations to
  river/conformance.md.
- Re-point TestLumpsMergeIntoTheSpeciesBirdViewCarries to
  dataset.scopeMatchesStatusTable, delete dead functions left behind by
  retired requirements and tools, and add TestNoUnreachableCode
  (repo.noUnreachableCode) with its test-oracle allowlist.
- Add a conditional river check job to .github/workflows/checks.yml and close
  adoptRiverWithdrawalCascade, composeDatasetAndRepo,
  separateRestatedRequirements, licenseConditionFirst, and
  attributionCriterionNamesAba.
Sameer approved the recomposed packages on PR #15; strict river check now
passes with no awaiting-approval notes.

@Sajmani Sajmani left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sajmani
Sajmani merged commit b9865a2 into main Nov 12, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant