Add -lpfm to pkg-config Libs.private when libpfm is enabled#2194
Open
kiwigitops wants to merge 1 commit into
Open
Add -lpfm to pkg-config Libs.private when libpfm is enabled#2194kiwigitops wants to merge 1 commit into
kiwigitops wants to merge 1 commit into
Conversation
LebedevRI
reviewed
May 22, 2026
Collaborator
LebedevRI
left a comment
There was a problem hiding this comment.
This should probably be using get_target_property() instead of
guessing the lib name, oh, and, this seems to completely not handle -L?
The private link library derivation skips CMake targets, so the PFM::libpfm imported target was never translated into linker flags. Static consumers using pkg-config then fail to resolve pfm_* symbols. Resolve imported targets through their IMPORTED_LOCATION and emit the corresponding -L/-l flags alongside the other private libraries.
568b121 to
4b81276
Compare
Author
|
Good points, updated. It now resolves the target via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
BENCHMARK_ENABLE_LIBPFM=ON, libpfm is linked into the benchmark library via thePFM::libpfmimported target. The pkg-config generation derivesLibs.privatefrom the target'sLINK_LIBRARIES, but the loop only emits-lflags for entries that are not CMake targets. Imported targets likePFM::libpfmare silently skipped, so-lpfmnever makes it intobenchmark.pc.As a result, projects that statically link benchmark through pkg-config fail to resolve
pfm_initialize/pfm_get_os_event_encodingat link time.This adds
-lpfmto the private link libraries for thePFM::libpfmtarget, alongside the existing private dependencies (-lpthread, etc.).Closes #1908.
Testing
git diff --check