Skip to content

Avoid repeated ASLR re-exec attempts #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiwigitops wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Avoid repeated ASLR re-exec attempts #2193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,11 @@ void MaybeReenterWithoutASLR(int /*argc*/, char** argv) {
if ((internal::get_as_unsigned(new_personality) & ADDR_NO_RANDOMIZE) == 0)
return;

// Some security profiles clear ADDR_NO_RANDOMIZE across exec even though the
// personality appears updated here. Avoid re-entering forever in that case.
constexpr const char* kAslrReexecEnv = "BENCHMARK_ASLR_NO_REEXEC";
if (std::getenv(kAslrReexecEnv) != nullptr) return;
if (setenv(kAslrReexecEnv, "1", 1) != 0) return;
execv(argv[0], argv);
// The exec() functions return only if an error has occurred,
// in which case we want to just continue as-is.
Expand Down