Parametrize metrics transmitter path. - #3100
Open
3405691582 wants to merge 1 commit into
Open
Conversation
Metrics are only written to disk when the transmitter binary exists. We only check a static path under /usr, the package destination. Thus, checking to see if metrics have been written to disk is only possible when the package is installed, and this requires root. For testing purposes, we might want to have metrics written to disk but without having the entire package installed, or we might be running in environments where we cannot install the transmitter to /usr. Instead, allow us to override the location of the transmitter binary, so we could potentially fake it out for testing purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics are only written to disk when the transmitter binary exists. We only check a static path under /usr, the package destination. Thus, checking to see if metrics have been written to disk is only possible when the package is installed, and this requires root.
For testing purposes, we might want to have metrics written to disk but without having the entire package installed, or we might be running in environments where we cannot install the transmitter to /usr. Instead, allow us to override the location of the transmitter binary, so we could potentially fake it out for testing purposes.