base: cvd: allocd: Search /usr/sbin for dnsmasq and fix PID file path - #3097
Queued
grandpaul wants to merge 1 commit into
Queued
base: cvd: allocd: Search /usr/sbin for dnsmasq and fix PID file path#3097grandpaul wants to merge 1 commit into
grandpaul wants to merge 1 commit into
Conversation
grandpaul
force-pushed
the
paulliu-fix-dnsmasq
branch
from
August 25, 2026 23:38
b891e63 to
1fbf032
Compare
In Debian, dnsmasq is located in /usr/sbin/dnsmasq which is not typically in non-root users' $PATH. Add SearchForDnsmasq and DnsmasqPath fallback helpers similar to IptablesPath. Also fix StopDnsmasq to use CvdDir() instead of hardcoded /var/run/ and fix inverted file.is_open() logic. Signed-off-by: Ying-Chun Liu (PaulLiu) <liupa@google.com>
grandpaul
force-pushed
the
paulliu-fix-dnsmasq
branch
from
August 26, 2026 00:10
1fbf032 to
ff6c1e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Debian, dnsmasq is located in /usr/sbin/dnsmasq which is not typically in non-root users' $PATH. Add SearchForDnsmasq and DnsmasqPath fallback helpers similar to IptablesPath. Also fix StopDnsmasq to use CvdDir() instead of hardcoded /var/run/ and fix inverted file.is_open() logic.