fix(6615):prevent silent drop of co-framed tool calls - #6677
Open
llalitkumarrr wants to merge 2 commits into
Open
fix(6615):prevent silent drop of co-framed tool calls#6677llalitkumarrr wants to merge 2 commits into
llalitkumarrr wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2. Or, if no issue exists, describe the change:
Problem:
A control-flow bug in GeminiLlmConnection.receive() (Issue #6615) caused tool calls to be silently discarded if they were co-framed frame as
turn_complete=True. The receive loop encountered an early break when evaluating turn completion, completely bypassing thetool_callblock.Solution:
Rearranged the order of the steps inside the loop. First it gathers all the text and audio, second it looks for any tool calls and safely stores them and finally it checks if the model has finished its turn (turn_complete).
Testing Plan
Added a dedicated async unit test (
test_receive_tool_call_and_turn_complete_in_same_message) that mocks a LiveServerMessage containing bothserver_content(with turn_complete=True) andtool_callin the same payload.