Skip to content

fix(litellm): avoid duplicate streamed tool-call content #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesynapses wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(litellm): avoid duplicate streamed tool-call content #6670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/models/lite_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3038,7 +3038,7 @@ def _finalize_tool_call_response(
llm_response = _message_to_generate_content_response(
ChatCompletionAssistantMessage(
role="assistant",
content="".join(text_parts),
content=None,
tool_calls=tool_calls,
),
model_version=model_version,
Expand Down
3 changes: 2 additions & 1 deletion tests/unittests/models/test_litellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4211,7 +4211,7 @@ async def test_generate_content_async_stream_grounding_metadata(


@pytest.mark.asyncio
async def test_generate_content_async_stream_with_usage_metadata(
async def test_generate_content_async_stream_tool_call_omits_aggregated_text(
mock_completion, lite_llm_instance
):

Expand All @@ -4234,6 +4234,7 @@ async def test_generate_content_async_stream_with_usage_metadata(
assert responses[2].content.parts[0].text == "two:"
assert responses[2].model_version == "test_model"
assert responses[3].content.role == "model"
assert len(responses[3].content.parts) == 1
assert responses[3].content.parts[-1].function_call.name == "test_function"
assert responses[3].content.parts[-1].function_call.args == {
"test_arg": "test_value"
Expand Down