fix(firestore): populate last_update_time in list_sessions from Firestore updateTime#5642
Closed
nileshpatil6 wants to merge 1 commit intogoogle:mainfrom
Closed
Conversation
…tore updateTime list_sessions() was hardcoding last_update_time=0.0 in every returned Session, ignoring the updateTime field stored in the Firestore document. get_session() already handles this correctly with an isinstance(datetime) check and a float() fallback. This commit applies the same conversion block to list_sessions(). Fixes google#5632
|
Thanks for working on this! This seems to overlap with #5640 (opened earlier), |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5632
Problem
list_sessions()hardcodeslast_update_time=0.0in every returnedSession, silently ignoring theupdateTimefield stored in the Firestore document. This means callers can never sort or filter sessions by last-update time when usingFirestoreSessionService.get_session()already handles this correctly:list_sessions()was missing this block entirely.Fix
Apply the same timestamp conversion in the
list_sessions()loop, immediately before constructing eachSession. Thedatetimeimport is already present at the top of the file.Behavior
session.last_update_timeis always0.0for every session returned bylist_sessions()session.last_update_timereflects the actual FirestoreupdateTime(a POSIX timestamp float)No other behavior changes -- the fix is additive and cannot break existing callers since
0.0was always wrong.