fix(cli): allow interspersed args for cloud_run command to support#4563
fix(cli): allow interspersed args for cloud_run command to support#4563khushi0433 wants to merge 1 commit intogoogle:mainfrom
Conversation
…verbosity and --log_level
Summary of ChangesHello @khushi0433, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical usability issue within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of interspersed arguments not being allowed in the cloud_run command by setting allow_interspersed_args=True. The fix is direct and effective. I have one minor suggestion regarding file formatting to adhere to Python's standard style guide.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
The
cloud_runCLI command was rejecting the documented debug options:--verbosity DEBUG--log_level DEBUGeven though these options were defined and visible in the CLI help output.
When running:
context_settings={
"allow_extra_args": True,
"allow_interspersed_args": False,
}
context_settings={
"allow_extra_args": True,
"allow_interspersed_args": True,
}