Draft
Conversation
…d auto-injection Close gaps between ADK's Agent Skills implementation and the public Agent Skills spec (agentskills.io/specification): - Frontmatter: add field validators for name (kebab-case, max 64), description (non-empty, max 1024), compatibility (max 500); add allowed-tools alias; add extra='allow'; add populate_by_name - Skill: add source_path field tracking SKILL.md location - utils: extract _parse_skill_md helper; use model_validate() for alias support; enforce name-dir matching; add validate_skill_dir() and read_skill_properties() - prompt: accept Union[Frontmatter, Skill]; emit <location> tag - skill_toolset: add scripts/ resource loading; auto-inject system instruction (with inject_instruction opt-out); duplicate name check; _list_skills() returns Skill objects - __init__: export validate_skill_dir, read_skill_properties - sample agent: remove manual instruction (auto-injected now); rename weather_skill dir to weather-skill Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Hello @caohy1988, thank you for your contribution! To help us review your pull request, please address the following:
Once these are addressed, we can proceed with the review. Thank you! Response from ADK Triaging Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name(kebab-case, max 64 chars),description(non-empty, max 1024 chars),compatibility(max 500 chars); addallowed-toolsYAML alias withpopulate_by_name=True; setextra='allow'source_path: Track the filesystem path to the loadedSKILL.md; emit<location>tag in XML prompt when available_parse_skill_md()helper; usemodel_validate()for alias support; enforce name-directory matching per spec; addvalidate_skill_dir()andread_skill_properties()public functionsscripts/resource loading viaload_skill_resource; auto-injectDEFAULT_SKILL_SYSTEM_INSTRUCTION(withinject_instruction=Falseopt-out); duplicate skill name check;_list_skills()returnsSkillobjects for richer XML outputinstruction=(auto-injected now); renameweather_skill/→weather-skill/to match spec naming requirementsCloses gaps against the Agent Skills spec.
Test plan
pytest tests/unittests/skills/ tests/unittests/tools/test_skill_toolset.py)./autoformat.sh)🤖 Generated with Claude Code