fix: issue 3772

[guillaumeblaquiere]

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Closes: Credential Manager mix user credential #3772

Problem:
The credential was asked only for the first user connected to the app. Then the credential_manager always served the previous exchange

Solution:
I removed the exchange check and use. I do not find other alternative. I didn't understand the usefulness of this check and use.

Testing Plan

No test broken

Manual End-to-End (E2E) Tests:

This removal solve the issue with multiple user in the same instance. Each of them must authenticated themselve

[gemini-code-assist]

Summary of Changes

Hello @guillaumeblaquiere, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the authentication flow where the credential_manager was reusing previously exchanged credentials, thereby allowing only the first user to authenticate successfully. The change ensures that each user is prompted for their own authentication by removing the problematic caching logic, leading to a more robust and correct multi-user experience.

Highlights

• Authentication Fix: Resolves an issue where the credential manager would incorrectly serve cached credentials, preventing multiple users from authenticating individually within the same application instance.
• Code Simplification: Removes a specific code block responsible for checking and returning a cached exchanged_auth_credential, which was identified as the root cause of the multi-user authentication problem.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @guillaumeblaquiere, thank you for creating this PR!

This PR is a bug fix, could you please provide logs or screenshot after the fix is applied?

This information will help reviewers to review your PR more efficiently. Thanks!

[gemini-code-assist]

Code Review

This pull request addresses a critical security issue where one user's credentials could be inadvertently used for another. The fix, which removes reading from the in-memory cached exchanged_auth_credential, is correct. This change effectively mitigates the problem by forcing a lookup from the user-specific credential service. The removed caching logic was likely intended for a single-user context but is unsafe in a multi-user environment where CredentialManager instances might be shared. I have one comment regarding follow-up changes to documentation and tests that are affected by this removal.

[guillaumeblaquiere]

@ryanaiagent @surajksharma07 I removed the useless (and in error) test because it tested the deleted line.

[ryanaiagent]

Hi @guillaumeblaquiere , we appreciate your patience and support. Can you please fix the failing unit tests.

[guillaumeblaquiere]

@ryanaiagent unit test fixed

[ryanaiagent]

/gemini review

[gemini-code-assist]

Code Review

The pull request addresses an issue with credential management for multiple users by removing an exchange check. It also includes an update to the pyproject.toml file to configure pythonpath for pytest, which is a good practice for module resolution. Additionally, several test mocks in test_remote_a2a_agent.py have been updated, primarily switching from create_autospec to MagicMock for A2AClient instances and directly accessing an agent's internal converter attribute.

[guillaumeblaquiere]

@ryanaiagent I commented the Gemini review.

Let me know the next steps

[ryanaiagent]

/gemini review

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with credential handling where credentials were being reused incorrectly for different users. However, the submitted changes only modify test utilities and project configuration (pyproject.toml). There don't appear to be any changes to the production code related to credential_manager or the "exchange check" mentioned in the description. It seems the core logic fix might be missing from this PR. Regarding the changes present, the main modification in the test file test_remote_a2a_agent.py is replacing create_autospec with MagicMock. This is generally discouraged as it makes tests less strict and less resilient to API changes. I've added specific comments suggesting to revert these changes.

[gemini-code-assist]

For better test robustness and to ensure the mock behaves as closely to the real object as possible, it's recommended to use create_autospec. It provides stricter checks, including method signatures, which can help catch breaking changes in the A2AClient API early. MagicMock is less strict and might let inconsistencies pass silently.

Suggested change

	mock_a2a_client = MagicMock(spec=A2AClient)
	mock_a2a_client = create_autospec(spec=A2AClient, instance=True)

[gemini-code-assist]

For better test robustness and to ensure the mock behaves as closely to the real object as possible, it's recommended to use create_autospec. It provides stricter checks, including method signatures, which can help catch breaking changes in the A2AClient API early. MagicMock is less strict and might let inconsistencies pass silently.

Suggested change

	mock_a2a_client = MagicMock(spec=A2AClient)
	mock_a2a_client = create_autospec(spec=A2AClient, instance=True)

[gemini-code-assist]

For better test robustness and to ensure the mock behaves as closely to the real object as possible, it's recommended to use create_autospec. It provides stricter checks, including method signatures, which can help catch breaking changes in the A2AClient API early. MagicMock is less strict and might let inconsistencies pass silently.

Suggested change

	mock_a2a_client = MagicMock(spec=A2AClient)
	mock_a2a_client = create_autospec(spec=A2AClient, instance=True)

[ryanaiagent]

Hi @guillaumeblaquiere , closing this since its already fixed in this commit