Skip to content

Conversation

@sugoi-yuzuru
Copy link
Collaborator

Description

Now that the common artifacts needed for web renderers (@a2ui/angular and @a2ui/lit) are refactored into @a2ui/web_core, @a2ui/lit package no longer needs to hold its own copy of the json schemas and reference them from the @a2ui/web_core package.

This PR cleans up the stale copies that could mislead the future developers.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Now that the common artifacts needed for web renderers (`@a2ui/angular` and `@a2ui/lit`) are refactored into `@a2ui/web_core`, `@a2ui/lit` package no longer needs to hold its own copy of the json schemas and reference them from the `@a2ui/web_core` package.

This PR cleans up the stale copies that could mislead the future developers.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to centralize JSON schemas into the @a2ui/web_core package by removing them from @a2ui/lit. The changes correctly remove the copy-spec script from @a2ui/lit and add the necessary exports to @a2ui/web_core. However, there is a critical issue where a required schema file is deleted instead of being moved, which will likely cause build failures. My review includes a comment detailing this issue.

I am having trouble creating individual review comments. Click here to see my feedback.

renderers/lit/src/0.8/schemas/server_to_client_with_standard_catalog.json (1-823)

critical

This file appears to be deleted, but it seems it should have been moved to renderers/web_core/src/v0_8/schemas/ instead. The @a2ui/web_core package now imports it in renderers/web_core/src/v0_8/index.ts:

import A2UIClientEventMessage from "./schemas/server_to_client_with_standard_catalog.json" with { type: "json" };

Without this file, the build for @a2ui/web_core will likely fail. Please move this file to renderers/web_core/src/v0_8/schemas/ instead of deleting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants