Skip to content

docs: fix ACP flags in CLI reference - #29011

Open
harshil-mistry wants to merge 2 commits into
google-gemini:mainfrom
harshil-mistry:fix-acp-flags-reference
Open

docs: fix ACP flags in CLI reference#29011
harshil-mistry wants to merge 2 commits into
google-gemini:mainfrom
harshil-mistry:fix-acp-flags-reference

Conversation

@harshil-mistry

Copy link
Copy Markdown

Summary

Fixes three problems in two adjacent rows of the CLI reference flags table: a flag that no longer exists, a wrong expansion of the ACP acronym, and the current --acp flag being missing while the deprecated one isn't labelled as deprecated.

Details

Removed --experimental-zed-integration. It isn't implemented — experimental-zed-integration / experimentalZedIntegration appears nowhere under packages/; the only occurrence in the repo was that documentation row.

Added --acp. packages/cli/src/config/config.ts registers it as "Starts the agent in ACP mode", and docs/cli/acp-mode.md already instructs people to run gemini --acp — but the reference table never mentioned it.

Marked --experimental-acp as deprecated. Its own description in the source says "(deprecated, use --acp instead)", which the table didn't reflect. I followed the phrasing the table already uses for --yolo ("Deprecated. ... Use X instead.") so it reads consistently.

Fixed the acronym. The row expanded ACP as "Agent Code Pilot". It's the Agent Client Protocol — the first line of docs/cli/acp-mode.md says so, and that's the name of the open protocol the mode implements.

The table's column padding is unchanged, so the diff is two rows out, two rows in.

Related Issues

Fixes #29010

How to Validate

Docs-only, verified against the source:

  1. grep -rn "experimental-zed-integration\|experimentalZedIntegration" packages/ — no results, confirming the removed flag isn't implemented.
  2. grep -n "\.option('acp'" packages/cli/src/config/config.ts — shows --acp with description "Starts the agent in ACP mode".
  3. The adjacent .option('experimental-acp', ...) registration carries the description "Starts the agent in ACP mode (deprecated, use --acp instead)", which is the basis for the deprecation note.
  4. docs/cli/acp-mode.md line 1 confirms the expansion "ACP (Agent Client Protocol)" and line 8 documents gemini --acp.
  5. Confirmed ./acp-mode.md resolves from docs/cli/cli-reference.md (both live in docs/cli/).

I also diffed every flag in the reference table against the options registered in config.ts to make sure I wasn't missing another stale row; --experimental-zed-integration was the only documented flag with no implementation.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed) — n/a, no code changed
  • Noted breaking changes (if any) — none
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux

Platform matrix left unchecked on purpose rather than ticked without being exercised — this is a single .md table with no code path. npm run preflight not run for the same reason; happy to run it if you want it recorded.

@harshil-mistry
harshil-mistry requested review from a team as code owners August 24, 2026 12:19
@google-cla

google-cla Bot commented Aug 24, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the CLI reference documentation to accurately reflect the current state of ACP (Agent Client Protocol) flags. It removes obsolete entries, introduces missing documentation for active flags, and corrects terminology to ensure consistency across the project's documentation.

Highlights

  • Documentation Cleanup: Removed the non-existent --experimental-zed-integration flag from the CLI reference table.
  • ACP Flag Updates: Added the missing --acp flag and marked --experimental-acp as deprecated to reflect current implementation.
  • Terminology Correction: Corrected the expansion of the ACP acronym from Agent Code Pilot to Agent Client Protocol.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/xs An extra small PR label Aug 24, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XS

  • Lines changed: 4
  • Additions: +2
  • Deletions: -2
  • Files changed: 1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CLI reference documentation to reflect changes in the ACP (Agent Client Protocol) flags. Specifically, the --experimental-acp flag has been deprecated in favor of the new --acp flag, and the --experimental-zed-integration flag has been removed. There are no review comments, so I have no feedback to provide.

Note: Security Review has been skipped due to the limited scope of the PR.

@gemini-cli gemini-cli Bot added the area/documentation Gemini CLI documentation tasks and issues label Aug 24, 2026
@harshil-mistry

Copy link
Copy Markdown
Author

@googlebot I signed it!

Empty commit; no file changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Gemini CLI documentation tasks and issues size/xs An extra small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: CLI reference lists a removed --experimental-zed-integration flag and omits --acp

1 participant