fix(core): strip quotes and handle block scalars in simple frontmatter parser - #29006
fix(core): strip quotes and handle block scalars in simple frontmatter parser#29006loulanyue wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the robustness of the simple frontmatter parser used as a fallback when standard YAML parsing fails. It ensures that metadata fields are cleaned of unnecessary quotes and correctly interprets block scalar indicators, preventing parsing errors and ensuring consistent data extraction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
There was a problem hiding this comment.
Code Review
This pull request introduces a stripQuotes helper function in skillLoader.ts to remove surrounding single or double quotes from the name and description fields when parsing frontmatter using the simple fallback parser. It also updates the parser to handle cases where the description starts with block scalar indicators (| or >), and adds a corresponding unit test. The review feedback suggests improving the block scalar detection by using startsWith to correctly handle chomping or indentation indicators (e.g., |-, >2) rather than only matching exact characters.
| const firstLine = descMatch[1].trim(); | ||
| const descLines = firstLine === '|' || firstLine === '>' ? [] : [firstLine]; |
There was a problem hiding this comment.
The current check firstLine === '|' || firstLine === '>' only matches exact block scalar indicators. However, in YAML, block scalars frequently use chomping indicators (e.g., |-, |+, >-, >+) or indentation indicators (e.g., |2, >2). If any of these are used, the simple parser fallback will fail to recognize them as block scalar indicators, resulting in the indicator (like |-) being prepended to the parsed description. Checking if the line starts with | or > is a more robust way to handle all block scalar variations.
| const firstLine = descMatch[1].trim(); | |
| const descLines = firstLine === '|' || firstLine === '>' ? [] : [firstLine]; | |
| const firstLine = descMatch[1].trim(); | |
| const descLines = firstLine.startsWith('|') || firstLine.startsWith('>') ? [] : [firstLine]; |
In
packages/core/src/skills/skillLoader.ts:skillLoader.test.ts.