Skip to content

fix(core): strip quotes and handle block scalars in simple frontmatter parser - #29006

Open
loulanyue wants to merge 1 commit into
google-gemini:mainfrom
loulanyue:fix/system-instruction-newline-normalization
Open

fix(core): strip quotes and handle block scalars in simple frontmatter parser#29006
loulanyue wants to merge 1 commit into
google-gemini:mainfrom
loulanyue:fix/system-instruction-newline-normalization

Conversation

@loulanyue

Copy link
Copy Markdown

In packages/core/src/skills/skillLoader.ts:

  • When YAML parsing fails and falls back to simple parsing, quoted values retained surrounding quotes in name and description.
  • Strip quotes and handle block scalar indicator pipes/greater-than signs gracefully.
  • Added unit tests in skillLoader.test.ts.

@loulanyue
loulanyue requested a review from a team as a code owner August 24, 2026 08:42
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the simple frontmatter parser used as a fallback when standard YAML parsing fails. It ensures that metadata fields are cleaned of unnecessary quotes and correctly interprets block scalar indicators, preventing parsing errors and ensuring consistent data extraction.

Highlights

  • Quote Stripping: Introduced a utility function to remove surrounding quotes from name and description fields during simple frontmatter parsing.
  • Block Scalar Handling: Updated the simple parser to gracefully handle YAML block scalar indicators like '|' and '>'.
  • Testing: Added a new unit test case to verify correct parsing behavior when YAML syntax is invalid and the simple fallback parser is triggered.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/s A small PR label Aug 24, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/S

  • Lines changed: 40
  • Additions: +37
  • Deletions: -3
  • Files changed: 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a stripQuotes helper function in skillLoader.ts to remove surrounding single or double quotes from the name and description fields when parsing frontmatter using the simple fallback parser. It also updates the parser to handle cases where the description starts with block scalar indicators (| or >), and adds a corresponding unit test. The review feedback suggests improving the block scalar detection by using startsWith to correctly handle chomping or indentation indicators (e.g., |-, >2) rather than only matching exact characters.

Comment on lines +98 to +99
const firstLine = descMatch[1].trim();
const descLines = firstLine === '|' || firstLine === '>' ? [] : [firstLine];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current check firstLine === '|' || firstLine === '>' only matches exact block scalar indicators. However, in YAML, block scalars frequently use chomping indicators (e.g., |-, |+, >-, >+) or indentation indicators (e.g., |2, >2). If any of these are used, the simple parser fallback will fail to recognize them as block scalar indicators, resulting in the indicator (like |-) being prepended to the parsed description. Checking if the line starts with | or > is a more robust way to handle all block scalar variations.

Suggested change
const firstLine = descMatch[1].trim();
const descLines = firstLine === '|' || firstLine === '>' ? [] : [firstLine];
const firstLine = descMatch[1].trim();
const descLines = firstLine.startsWith('|') || firstLine.startsWith('>') ? [] : [firstLine];

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant