fix(ci): provide fallbacks for package variables in nightly release#28016
Merged
Conversation
The nightly release workflow uses the 'internal' environment on schedule triggers, which does not have the package name variables defined. This led to empty strings being passed to the publish action, causing npm to fail with 'No workspaces found: --workspace='.
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
📊 PR Size: size/S
|
gemini-cli
Bot
added
priority/p1
|
Size Change: -4 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
DavidAPierce
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the nightly release workflow failing during the publish step for scheduled runs. Scheduled runs use the
internalenvironment which does not define the package name variables, resulting innpm publishreceiving empty workspace names and failing. This adds default fallbacks for these variables.Details
The scheduled
release-nightly.ymlworkflow was changed recently to use theinternalenvironment instead ofprod. Theinternalenvironment doesn't have thevars.CLI_PACKAGE_NAME,vars.CORE_PACKAGE_NAME, andvars.A2A_PACKAGE_NAMErepository variables configured. Consequently, they evaluate to empty strings, causing thenpm publish --workspace=""command to fail with an errornpm error No workspaces found.This PR adds default values to the variables directly in the workflow file.
Related Issues
Fixes #28001 (Scheduled release failure)
How to Validate
Release: Nightlyworkflow via workflow_dispatch with theinternalenvironment (if possible) or review the generated variables.@google/gemini-cli,@google/gemini-cli-core, and@google/gemini-cli-a2a-server.Pre-Merge Checklist