-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update julia version to v1.10 #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update julia version to v1.10 #1380
Conversation
|
Ok great!! Thanks. However, can you re-enable the Julia tests to it runs on Github Actions and we can see how long it takes? i.e. uncomment this: https://github.com/findmyway/open_spiel/blob/58b81463b4394772d72ba21d0a891acc7510245e/open_spiel/julia/CMakeLists.txt#L17 |
|
The CI failed. But I can't reproduce it with my local Mac environment. JuliaInterop/CxxWrap.jl#475 seems to be related. I'll find a linux environment and see how to fix it later. I can reproduce it in a Linux environment. But the proposed fix in the issue above is a little bit tricky. Prefer to integrate #1379 first. |
|
Ok @findmyway , #1379 has been merged. Do you have any idea how much use the Julia API is getting? I've been slowly deprecating the other APIs that are unused (leaving them in the repos but marked as unmaintained) if anybody wants to resurrect or help support them. I am wondering if the Julia API still worth the maintenance burden.. wdyt? |
This is the only place I know to check it: https://juliapkgstats.com/pkg/OpenSpiel
I fully understand that and agree that we can deprecate it slowly. |
|
Ran into another problem with Julia that was causing the CI tests to fail: |
|
As a result of the above, I've set |
|
Probably makes sense to deprecate the Julia API now then @findmyway, it's getting to be a bit too hard for me to maintain myself. So I'll close this PR but please re-open if you're able to find a fix. |
Julia@v1.10is the new Long-term support (LTS) release. This PR is an attempt to update the julia dependency.Note that #1379 is already integrated into this PR.
Though the tests are passed now, most of changes are introduced due to JuliaInterop/CxxWrap.jl#400 (comment) Ideally, we can have an option to turn on the original auto converting feature so that we don't need those verbose
[]dereference operations.