fix: follows symbolic links with formatter exclusion paths #6180
+147
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ln -s worktree wt && cd wt && golangci-lint fmt' now works Signed-off-by: David L. Chandler <david.chandler@solo.io>
|
|
|
Hey, thank you for opening your first Pull Request ! |
ldez
changed the title
ldez
changed the title
ldez
force-pushed
the
chandler/symlink-fmt
branch
from
e7aa83f to
f467aa2
Compare
Member
|
The problem supposedly fixed by this PR "issue with the 'fmt' command and symbolic links" is not fixed. At first, I was thinking the PR title was wrong because the only change was in the exclusions system. But in fact, this PR fixes nothing, because the problem with symlinks is not here. This is why it's better to open an issue before opening a PR, and when opening a PR, a real description is important. I close this PR, and I will try to create the real fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ln -s worktree wt && cd wt && golangci-lint fmtnow works