Skip to content

[3.x] Add generics to PackedScene instance #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronfranke wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

[3.x] Add generics to PackedScene instance #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions binding_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,20 @@ def escape_default_arg(_type, default_value):
source.append("\treturn get_node_internal(path);")
source.append("}")
source.append("")
elif use_template_get_node and class_name == "PackedScene":
source.append("\ttemplate <class T = Node>")
source.append("\tT *instance(const int64_t edit_state = 0) const {")
source.append("\t\treturn Object::cast_to<T>(instance(edit_state));")
source.append("\t}")

source.append("};")
source.append("")

source.append("template <>")
source.append("inline Node *PackedScene::instance<Node>(const int64_t edit_state) const {")
source.append("\treturn instance(edit_state);")
source.append("}")
source.append("")
else:
source.append("};")
source.append("")
Expand Down