Add back support for Godot 4.3 #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
v10-support-43
branch
from
854a778 to
a6103ac
Compare
dsnopek
force-pushed
the
v10-support-43
branch
5 times, most recently
from
92b8f48 to
107bbac
Compare
dsnopek
force-pushed
the
v10-support-43
branch
from
107bbac to
7074059
Compare
dsnopek
force-pushed
the
v10-support-43
branch
from
7074059 to
ce18d99
Compare
dsnopek
changed the title
Collaborator
Author
|
Taking out of DRAFT now that #1898 is merged! |
Ivorforce
approved these changes
Jan 15, 2026
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Same as last version, LGTM!
I've got a GDExtension that I'm planning to keep at 4.3 for the time being, so I'm hoping to test this soon. But no need to wait for that, if I run into issues I can open follow-up PRs with fixes.
| #else | ||
| // Note: This isn't safe, because the object may have already been freed, but it's the best we | ||
| // can do in Godot 4.3 and earlier. | ||
| Object *obj = operator Object *(); |
Member
There was a problem hiding this comment.
Isn't get_validated_object available in 4.3? Edit: Ah, it depends on operator ObjectID()...
Collaborator
Author
There was a problem hiding this comment.
Yeah, we didn't have a way to get the ObjectID from the Variant back in 4.3 and earlier, which is why variant_get_object_instance_id was added to the GDExtension interface in 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next "godot-cpp v10" PR - it builds on top of:
api_versionbuild option to select the API JSON file #1897This one adds back support for Godot 4.3, and includes the
extension_api.jsonfor 4.3, such that you can build viascons api_version=4.3out-of-the-boxThis one was the trickiest so far, and will definitely need more testing before we can merge it. It's also made me think that perhaps supporting back to Godot 4.3 is far enough?
The changes we'd need to make for Godot 4.2 and 4.1 would be pretty extensive (given how much stuff we changed back then) and probably not all that worth it, given how old those versions are.
Also, Godot 4.3 is the earliest version that supports loading documentation from a GDExtension, which seems like a good reason for targeting that as a minimum.
Marked as DRAFT because it depends on the other "godot-cpp v10" PRs