Skip to content

Replace std::set with HashSet #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dementive wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace std::set with HashSet #1843

dementive wants to merge 1 commit into from

Conversation

@dementive
Copy link
Contributor

@dementive dementive commented Sep 10, 2025

This removes all of the std::set usage and replaces it with Godot's RBSet.

I'm making this a draft for now because it will not compile until #1841 gets merged, but once it does it will work fine.

@Ivorforce
Copy link
Member

Ivorforce commented Sep 11, 2025

Note that HashSet is the recommended default 'set' type for Godot, the benefits of RBSet are not clearly established.

@Calinou Calinou added the enhancement This is an enhancement on the current functionality label Sep 11, 2025
@dementive
Copy link
Contributor Author

dementive commented Sep 11, 2025 •
edited
Loading

Note that HashSet is the recommended default 'set' type for Godot, the benefits of RBSet are not clearly established.

Just changed it to make it HashSet.

@dementive dementive force-pushed the no-std-set branch 2 times, most recently from 78af2d5 to b792368 Compare September 12, 2025 20:23
@dementive dementive changed the title Replace std::set with RBSet Replace std::set with HashSet Sep 12, 2025
@dementive dementive marked this pull request as ready for review October 4, 2025 23:06
@dementive dementive requested a review from a team as a code owner October 4, 2025 23:07
@dsnopek dsnopek added this to the 4.x milestone Oct 5, 2025
dsnopek
dsnopek approved these changes Oct 5, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 16, 2025

Looks like this one needs a rebase

Ivorforce
Ivorforce approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, this still needs a rebase. @dementive Are you still available to enact this?

@dementive
Copy link
Contributor Author

dementive commented Jan 15, 2026 •
edited
Loading

Yeah, I'll rebase this and the other one later today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

@Ivorforce Ivorforce Ivorforce approved these changes

Assignees

No one assigned

Labels

cherrypick:4.4 cherrypick:4.5 enhancement This is an enhancement on the current functionality

Projects

None yet

Milestone

4.x

Development

Successfully merging this pull request may close these issues.

4 participants

@dementive @Ivorforce @dsnopek @Calinou