-
Notifications
You must be signed in to change notification settings - Fork 23
feat(domain): migrate domain list to v3, add premium/pricing support #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7f505a8
feat(domain): migrate domain list to v3 listDomains, add premium/pric…
jpage-godaddy 0f39c95
fix(domain): fix doc comment referring to the wrong command name
jpage-godaddy 92e8715
test(domain): pin statuses/lifecycleGroups as single comma-joined params
jpage-godaddy 418ee51
fix(domain): fetch every page of domain list, not just the first
jpage-godaddy cd0d188
fix(domain): actually error when MAX_PAGES is exceeded
jpage-godaddy d41b820
fix(domain): parse pagination links without requiring an absolute URL
jpage-godaddy 3297c67
fix(domain): restore dropped DNS PUT safety comment, fail fast on fee…
jpage-godaddy 71482b0
fix(domain): avoid double-uppercasing statuses, drop null type from f…
jpage-godaddy ecf79c1
test(domain): add regression tests for quote's inventory/fees rendering
jpage-godaddy 74a1bad
fix(domain): error on an unparseable next link instead of stopping si…
jpage-godaddy 7952625
fix(domain): avoid integer overflow computing the fetch stop_at bound
jpage-godaddy ceaa051
fix(domain): fall back to firstTermPrice for shared_currency
jpage-godaddy 2a53a87
test(domain): pin that empty acknowledgedFees/fees are omitted, not s…
jpage-godaddy 2cff614
docs(domains-client): fix stale 1-50 domain references to match the 2…
jpage-godaddy 2489e12
docs(domains-client): note the temporary OTE host in regenerate-spec.sh
jpage-godaddy 51407c4
fix(domain): treat invalid pageTokenDirection as unparseable, keep cu…
jpage-godaddy 77317e1
fix(domain): stop gating terms on currency being derivable
jpage-godaddy c4955b9
fix(domain): keep searching for a currency code across all terms
jpage-godaddy f11ee67
fix(domains-client): sync spec against production, no drift found
jpage-godaddy d9d3c8b
chore(domains-client): drop dead v1 domain-list code, automate spec p…
jpage-godaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.