Skip to content

docs: refine G115 guidance for CodeQL analyzer flow #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spiegel-im-spiegel merged 1 commit into from
May 26, 2026
Merged

docs: refine G115 guidance for CodeQL analyzer flow #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ golangci-lint-v2 run --enable gosec --timeout 3m0s ./...
- For file path handling, prefer sanitizing with `filepath.Clean` before opening files.
- Avoid using `#nosec G304` as the first option when path normalization can mitigate the warning.
- For narrowing integer conversions (`G115`), prefer explicit range checks before conversion.
- If linter still reports a false positive after range checks, allow minimal `#nosec G115` with a reason comment.
- Prefer analyzer-friendly control flow: return early for invalid/null paths first, then apply range checks, then convert.
- If linter or CodeQL still reports a false positive after that, allow minimal `#nosec G115` with a reason comment.
- Prefer clear conversions over bit-mask tricks for readability.
- After range checks, use direct conversion (e.g. `byte(v)`), not masking (e.g. `byte(v & 0xff)`).

Expand Down
Loading