Potential fix for gettimeofday for Arduino
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can merge this change, but I would still wait to fully understand why the weak symbol resolution failed. If it's a compiler problem beyond out reach to fix, we can take this route. |
sidcha
reviewed
Nov 26, 2025
Member
sidcha
left a comment
sidcha
left a comment
There was a problem hiding this comment.
Like I said, if we are going this route, we need to support Arduio as a proper platform in C-Utils.
| return micros(); | ||
| } | ||
|
|
||
| void get_time(uint32_t *seconds, uint32_t *micro_seconds) |
Member
There was a problem hiding this comment.
The idea here is that different platforms expose a gettimeofday() and then the usec_*() methods just consume them. Can you change this code to be one of the recognised platforms above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for goToMain/libosdp#257. It does fix that issue for the Arduino platform specifically, but this may not be the best solution.