Repository navigation
font5x7: every printable ASCII character draws, and ’ — · too - #487
Merged
Merged
Conversation
Fifteen printable ASCII characters had no glyph -- @ " $ & ' ; [ \ ] ^ ` { | } ~
-- and drew as a blank of the right width: an e-mail address lost its @, an
IPv6 address its brackets, a quoted name its quotes, a URL its & and ~. Found
in the go-fileshare console, whose status line read "fileshare s provisioner".
The shapes are the classic 5x7 table's, which the existing rows come from;
each was rendered and checked by eye. Also the typographic apostrophe, the em
dash and the middle dot. A new test requires all of printable ASCII, with a
lit glyph; the tests that used ~ and the apostrophe as unknown characters use
é and € now.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in 5x7 font had no glyph for 15 printable ASCII characters:
@ " $ & ' ; [ \ ] ^{ | }. Each drew as a blank of the right width, so nothing said a character was missing: an e-mail address lost its@, an IPv6 address its brackets, a URL its&and#and%already match it). Each was rendered as ASCII art and checked by eye.’(typographic apostrophe: "l’accès", "it’s"),—and·.TestBitmapCoversPrintableASCII: every rune 0x20–0x7E has a glyph that lights at least one pixel (the space excepted).~and'as examples of unknown characters now useéand€;BitmapMissing("café à 10 €")lists é, à, €.For callers: text that relied on these characters drawing blank (unlikely) will now show them. Workarounds such as go-xrkit/desk's rule against apostrophes are no longer needed for these characters. Accented letters are still not covered: that would be a larger, separate change.
Full suite passes.
TestCollabTextConcurrentEditsConvergetimed out once in a full local run under load; it passes 5/5 on this branch and 3/3 on main, and this change does not touch it.🤖 Generated with Claude Code